-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STELLAR-3554 : add support for stream resume, frame bundling #110
Conversation
davidk81
commented
Jun 2, 2020
•
edited
Loading
edited
- support for frame bundling
- support for stream resume
- grpc flow control with client telemetry message ack
I was testing the current release of the CLI and found go-grpc threw an error when the message size was over 4MB or so. I think there's a limit on the client too? |
do we need to make |
i think this is ready for review |
Do we print the ack ID anywhere? I don't think we need to have an argument for this since the CLI is handling this automatically. I couldn't imagine a user somehow recording the ack ID from CLI output and having a process restart the CLI with the recorded ack ID-- at this point it would be easier to just use the API directly 😄 |
Co-authored-by: Bianca Woo <18028868+woobianca@users.noreply.github.com>
not sure if this solves that problem, but this might be the way to set maxMessageSize in grpc-go. i didn't bother to figure out how to send messages > 4MB with starpass so i didn't test this. |